Ignore statements that have no query id - #840
Merged
Merged
Conversation
artemgavrilov
force-pushed
the
no_query_id
branch
from
September 2, 2026 17:30
743b56e to
70483b7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
+ Coverage 88.42% 88.50% +0.08%
==========================================
Files 3 3
Lines 1339 1340 +1
Branches 194 196 +2
==========================================
+ Hits 1184 1186 +2
Misses 75 75
+ Partials 80 79 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Match pg_stat_statements behavior and ignore statements without query id. Otherwise all such statements stats will be merged into single entry as query id part of the hash key.
artemgavrilov
force-pushed
the
no_query_id
branch
from
September 2, 2026 18:11
70483b7 to
1ea0e03
Compare
artemgavrilov
marked this pull request as ready for review
September 2, 2026 20:41
artemgavrilov
commented
Sep 2, 2026
jeltz
approved these changes
Sep 3, 2026
jeltz
left a comment
jeltz
left a comment
Contributor
There was a problem hiding this comment.
Do you want this in 2.4.0?
Contributor
Author
I think we can keep it for the next release. It's not good, but not critical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match pg_stat_statements behavior and ignore statements without query id. Otherwise all such statements stats will be merged into single entry as query id part of the hash key.
PG-0
Description
Links